You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: respect per-flag insightsEnabled for evaluation events - #21
Feature flags with insightsEnabled: false currently still produce evaluation events. Suppress those records while keeping evaluation values, variation IDs, match reasons, and experiment eligibility unchanged. Missing, null, and non-boolean settings retain the evaluation server's default-enabled behavior.
Summary by CodeRabbit
Bug Fixes
Flag evaluation events are now collected only when insights are enabled. Setting insightsEnabled to false disables collection; missing or other values leave it enabled.
This applies to standard evaluations and later access to previously evaluated flag states. Offline and closed-client event suppression remains unchanged.
Documentation
Clarified when flag evaluation events are collected and how the insights setting affects them.
Confidence Score: 5/5
The PR appears safe to merge; no actionable issue was found.
Summary
The PR suppresses evaluation events when a flag’s insightsEnabled value is explicitly false, without changing evaluation results or experiment eligibility.
Flags with insights disabled stop adding evaluation events.
No actionable comments were generated in the recent review.
Walkthrough
Evaluation events are collected unless insightsEnabled is explicitly false. Event eligibility is captured during evaluation. Evaluation results and other event types remain unchanged.
The evaluator omits flag events only when insights are explicitly false. The client skips ineligible flag events. Tests cover synchronized and external flag data, evaluations, updates, snapshots, and existing event suppression. Documentation describes the behavior.
Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: applying per-flag insightsEnabled settings to evaluation events.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 7 functions across 4 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 2bee0836-43d7-47c2-8af7-ec62e2c1605b
Commits
Reviewing files that changed from the base of the PR and between db68035 and a1ab7a2.
Files selected for processing: 5
README.md
fbclient/client.py
fbclient/common_types.py
fbclient/evaluator.py
tests/test_insights_enabled.py
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature flags with
insightsEnabled: falsecurrently still produce evaluation events. Suppress those records while keeping evaluation values, variation IDs, match reasons, and experiment eligibility unchanged. Missing, null, and non-boolean settings retain the evaluation server's default-enabled behavior.Summary by CodeRabbit
insightsEnabledtofalsedisables collection; missing or other values leave it enabled.
The PR appears safe to merge; no actionable issue was found.Summary
The PR suppresses evaluation events when a flag’s
insightsEnabledvalue is explicitlyfalse, without changing evaluation results or experiment eligibility.Reviews (2) · Last reviewed commit: "Remove evaluation insights section from ..." · Reviewed by Greptile